Mibew/mibew
1
0
Fork 0
mirror of https://github.com/Mibew/mibew.git synced 2025-01-31 05:20:30 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix handling of obsolete information on updates

Browse Source
This commit is contained in:
Fedor A. Fetisov 2018-02-06 01:28:48 +03:00
parent 64e902c5a1
commit efa1372cdc
1 changed files with 51 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
src/mibew/libs/classes/Mibew/Maintenance/UpdateChecker.php
View File

@ -245,20 +245,25 @@ class UpdateChecker
protected function processUpdates($updates) protected function processUpdates($updates)
{ {
// Process updates of the core. // Process updates of the core.
$success = false;
if (version_compare($updates['core']['version'], MIBEW_VERSION) > 0) { if (version_compare($updates['core']['version'], MIBEW_VERSION) > 0) {
$update = $updates['core']; $update = $updates['core'];
// Save info about update for the core only if its version changed // Save info about update for the core only if its version changed.
$success = $this->saveUpdate( $success = $this->saveUpdate(
'core', 'core',
$update['version'], $update['version'],
$update['download'], $update['download'],
empty($update['description']) ? '' : $update['description'] empty($update['description']) ? '' : $update['description']
); );
if (!$success) { }
// Something went wrong. The error is already logged so just else {
// notify the outer code. // Remove obsolete info if core already was updated.
return false; $success = $this->deleteUpdate('core');
} }
if (!$success) {
// Something went wrong. The error is already logged so just
// notify the outer code.
return false;
} }
// Process plugins updates. // Process plugins updates.
@ -271,19 +276,21 @@ class UpdateChecker
} }
$info = $plugins_info[$plugin_name]; $info = $plugins_info[$plugin_name];
$success = false;
if (version_compare($update['version'], $info['version']) <= 0) { if (version_compare($update['version'], $info['version']) > 0) {
// Version of the plugin is not updated. Just do nothing. // Save the update
continue; $success = $this->saveUpdate(
$plugin_name,
$update['version'],
$update['download'],
empty($update['description']) ? '' : $update['description']
);
}
else {
// Version of the plugin is not updated. Remove obsolete info if need to.
$success = $this->deleteUpdate($plugin_name);
} }
// Save the update
$success = $this->saveUpdate(
$plugin_name,
$update['version'],
$update['download'],
empty($update['description']) ? '' : $update['description']
);
if (!$success) { if (!$success) {
// Something went wrong. The error is already logged so just // Something went wrong. The error is already logged so just
// notify the outer code. // notify the outer code.
@ -329,6 +336,33 @@ class UpdateChecker
return true; return true;
} }
/**
* Deletes record about available update from the database.
*
* @param string $target Update's target. Can be either "core" or fully
* qualified plugin's name.
* @return boolean False on failure and true otherwise. To get more info
* about the error call {@link UpdateChecker::getErrors()} method.
*/
protected function deleteUpdate($target)
{
try {
$update = AvailableUpdate::loadByTarget($target);
if (!$update) {
// There is no such update in the database. Do nothing.
return true;
}
$update->delete();
} catch (\Exception $e) {
$this->errors[] = 'Cannot delete obsolete update: ' + $e->getMessage();
return false;
}
return true;
}
/** /**
* Builds human-readable message about error in json_* PHP's function. * Builds human-readable message about error in json_* PHP's function.
* *