Mibew/mibew
1
0
Fork 0
mirror of https://github.com/Mibew/mibew.git synced 2025-02-07 16:24:43 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make sure all for-in loops works as expected

Browse Source
This commit is contained in:
Dmitriy Simushev 2016-06-02 23:20:24 +00:00
parent 199438285c
commit d5130ed655
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mibew/js/source/default/server.js
View File

@ -377,9 +377,7 @@
} }
try { try {
var packageObject = this.mibewAPI.decodePackage(data); var packageObject = this.mibewAPI.decodePackage(data);
// TODO: Try to use 'for' loop instead of 'for in' loop for (var i = 0, len = packageObject.requests.length; i < len; i++) {
// or use hasOwnProperty method
for (var i in packageObject.requests) {
this.processRequest(packageObject.requests[i]); this.processRequest(packageObject.requests[i]);
} }
} catch (e) { } catch (e) {

4
src/mibew/js/source/mibewapi.js
View File

@ -87,6 +87,10 @@ MibewAPI.prototype.checkFunction = function(functionObject, filterReservedFuncti
); );
argumentsLoop: argumentsLoop:
for (var argName in functionObject.arguments){ for (var argName in functionObject.arguments){
if (!functionObject.arguments.hasOwnProperty(argName)) {
// Work with own properties only.
continue;
}
for (var i = 0; i < mandatoryArgumentsList.length; i++) { for (var i = 0; i < mandatoryArgumentsList.length; i++) {
if (argName == mandatoryArgumentsList[i]) { if (argName == mandatoryArgumentsList[i]) {
mandatoryArgumentsCount++; mandatoryArgumentsCount++;