Mibew/mibew
1
0
Fork 0
mirror of https://github.com/Mibew/mibew.git synced 2025-01-31 05:20:30 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix issue with invalid management of session cookies in some browsers leading to "attack of clones"

Browse Source
This commit is contained in:
Fedor A. Fetisov 2021-08-24 22:41:20 +03:00
parent cd22f3e9d8
commit b6a70659b1
1 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/mibew/libs/chat.php
View File

@ -563,6 +563,8 @@ function setup_chatview_for_operator(
*/ */
function visitor_from_request() function visitor_from_request()
{ {
$tmp_request = Request::createFromGlobals();
$default_name = getlocal("Guest"); $default_name = getlocal("Guest");
$user_name = $default_name; $user_name = $default_name;
if (isset($_COOKIE[USERNAME_COOKIE_NAME])) { if (isset($_COOKIE[USERNAME_COOKIE_NAME])) {
@ -573,17 +575,33 @@ function visitor_from_request()
} }
if ($user_name == $default_name) { if ($user_name == $default_name) {
$temp = Request::createFromGlobals()->query->get('name'); $temp = $tmp_request->query->get('name');
$user_name = (isset($temp) && ($temp !== '')) ? $temp : $user_name; $user_name = (isset($temp) && ($temp !== '')) ? $temp : $user_name;
} }
if (isset($_COOKIE[USERID_COOKIE_NAME])) { if (isset($_COOKIE[USERID_COOKIE_NAME])) {
$user_id = $_COOKIE[USERID_COOKIE_NAME]; $user_id = $_COOKIE[USERID_COOKIE_NAME];
} else { } else {
$user_id = uniqid('', true); // Check whether user id already exists in absence of the appropriate cookie:
setcookie(USERID_COOKIE_NAME, $user_id, time() + 60 * 60 * 24 * 365); // some browsers could have weird behaviour
$temp = $tmp_request->query->get('user_id');
$user_id = (isset($temp)) ? $temp : uniqid('', true);
$cookie_properties = array( 'expires' => time() + 60 * 60 * 24 * 365 );
if (version_compare(phpversion(), '7.3.0', '<')) {
setcookie(USERID_COOKIE_NAME, $user_id, $cookie_properties['expires']);
}
else {
if ($tmp_request->isSecure()) {
$cookie_properties['samesite'] = 'None';
$cookie_properties['secure'] = true;
}
setcookie(USERID_COOKIE_NAME, $user_id, $cookie_properties);
}
} }
unset($tmp_request);
return array('id' => $user_id, 'name' => $user_name); return array('id' => $user_id, 'name' => $user_name);
} }