Do not use global $page array in setup_settings_tabs func

This commit is contained in:
Dmitriy Simushev 2014-01-15 15:29:35 +00:00
parent 4aff809fcb
commit ab52444bfd
7 changed files with 18 additions and 11 deletions

View File

@ -18,19 +18,26 @@
// Import namespaces and classes of the core // Import namespaces and classes of the core
use Mibew\Settings; use Mibew\Settings;
function setup_settings_tabs($active) /**
{ * Builds list of the system settings tabs. The keys of the resulting array are
global $page; * tabs titles and the values are tabs URLs.
$page['tabs'] = array( *
* @param int $active Number of the active tab
*/
function setup_settings_tabs($active) {
$tabs = array(
getlocal("page_settings.tab.main") => $active != 0 ? (MIBEW_WEB_ROOT . "/operator/settings.php") : "", getlocal("page_settings.tab.main") => $active != 0 ? (MIBEW_WEB_ROOT . "/operator/settings.php") : "",
getlocal("page_settings.tab.features") => $active != 1 ? (MIBEW_WEB_ROOT . "/operator/features.php") : "", getlocal("page_settings.tab.features") => $active != 1 ? (MIBEW_WEB_ROOT . "/operator/features.php") : "",
getlocal("page_settings.tab.performance") => $active != 2 ? (MIBEW_WEB_ROOT . "/operator/performance.php") : "", getlocal("page_settings.tab.performance") => $active != 2 ? (MIBEW_WEB_ROOT . "/operator/performance.php") : "",
getlocal("page_settings.tab.page_themes") => $active != 3 ? (MIBEW_WEB_ROOT . "/operator/page_themes.php") : "", getlocal("page_settings.tab.page_themes") => $active != 3 ? (MIBEW_WEB_ROOT . "/operator/page_themes.php") : "",
getlocal("page_settings.tab.themes") => $active != 4 ? (MIBEW_WEB_ROOT . "/operator/themes.php") : "", getlocal("page_settings.tab.themes") => $active != 4 ? (MIBEW_WEB_ROOT . "/operator/themes.php") : "",
); );
if (Settings::get('enabletracking')) { if (Settings::get('enabletracking')) {
$page['tabs'][getlocal("page_settings.tab.invitationthemes")] = ($active != 5 ? (MIBEW_WEB_ROOT . "/operator/invitationthemes.php") : ""); $tabs[getlocal("page_settings.tab.invitationthemes")] = ($active != 5 ? (MIBEW_WEB_ROOT . "/operator/invitationthemes.php") : "");
} }
return $tabs;
} }
?> ?>

View File

@ -71,7 +71,7 @@ $page['title'] = getlocal("settings.title");
$page['menuid'] = "settings"; $page['menuid'] = "settings";
prepare_menu($operator); prepare_menu($operator);
setup_settings_tabs(1); $page['tabs'] = setup_settings_tabs(1);
$page_style = new PageStyle(PageStyle::currentStyle()); $page_style = new PageStyle(PageStyle::currentStyle());
$page_style->render('features'); $page_style->render('features');

View File

@ -44,7 +44,7 @@ $page['title'] = getlocal("page.preview.title");
$page['menuid'] = "settings"; $page['menuid'] = "settings";
prepare_menu($operator); prepare_menu($operator);
setup_settings_tabs(5); $page['tabs'] = setup_settings_tabs(5);
$page_style = new PageStyle(PageStyle::currentStyle()); $page_style = new PageStyle(PageStyle::currentStyle());
$page_style->render('invitation_themes'); $page_style->render('invitation_themes');

View File

@ -53,7 +53,7 @@ $page['title'] = getlocal("page.preview.title");
$page['menuid'] = "settings"; $page['menuid'] = "settings";
prepare_menu($operator); prepare_menu($operator);
setup_settings_tabs(3); $page['tabs'] = setup_settings_tabs(3);
$page_style = new PageStyle(PageStyle::currentStyle()); $page_style = new PageStyle(PageStyle::currentStyle());
$page_style->render('page_themes'); $page_style->render('page_themes');

View File

@ -129,7 +129,7 @@ $page['title'] = getlocal("settings.title");
$page['menuid'] = "settings"; $page['menuid'] = "settings";
prepare_menu($operator); prepare_menu($operator);
setup_settings_tabs(2); $page['tabs'] = setup_settings_tabs(2);
$page_style = new PageStyle(PageStyle::currentStyle()); $page_style = new PageStyle(PageStyle::currentStyle());
$page_style->render('performance'); $page_style->render('performance');

View File

@ -160,7 +160,7 @@ if (Settings::get('enabletracking')) {
} }
prepare_menu($operator); prepare_menu($operator);
setup_settings_tabs(0); $page['tabs'] = setup_settings_tabs(0);
$page_style = new PageStyle(PageStyle::currentStyle()); $page_style = new PageStyle(PageStyle::currentStyle());
$page_style->render('settings'); $page_style->render('settings');

View File

@ -59,7 +59,7 @@ $page['title'] = getlocal("page.preview.title");
$page['menuid'] = "settings"; $page['menuid'] = "settings";
prepare_menu($operator); prepare_menu($operator);
setup_settings_tabs(4); $page['tabs'] = setup_settings_tabs(4);
$page_style = new PageStyle(PageStyle::currentStyle()); $page_style = new PageStyle(PageStyle::currentStyle());
$page_style->render('themes'); $page_style->render('themes');