Mibew/mibew
1
0
Fork 0
mirror of https://github.com/Mibew/mibew.git synced 2025-01-31 13:24:41 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Move request preparation and finalization to special methods

Browse Source
This commit is contained in:
Dmitriy Simushev 2014-10-06 09:06:11 +00:00
parent 952ebf8b9d
commit a61b48252c
3 changed files with 52 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mibew/index.php
View File

@ -41,5 +41,4 @@ $request = Request::createFromGlobals();
$response = $application->handleRequest($request);
// Send response to the user
$response->prepare($request);
$response->send();

1
src/mibew/install.php
View File

@ -43,5 +43,4 @@ $request = Request::createFromGlobals();
$response = $application->handleRequest($request);
// Send response to the user
$response->prepare($request);
$response->send();

83
src/mibew/libs/classes/Mibew/Application.php
View File

@ -105,24 +105,7 @@ class Application implements RouterAwareInterface, AuthenticationManagerAwareInt
*/
public function handleRequest(Request $request)
{
// Actualize request context in the internal router instance
$context = new RequestContext();
$context->fromRequest($request);
$this->getRouter()->setContext($context);
// Make cookie creation easy
$cookie_factory = CookieFactory::fromRequest($request);
$authentication_manager = $this->getAuthenticationManager();
// Actualize cookie factory in the authentication manager if it is
// needed.
if ($authentication_manager instanceof CookieFactoryAwareInterface) {
$authentication_manager->setCookieFactory($cookie_factory);
}
$authentication_manager->setOperatorFromRequest($request);
// Actualize AssetUrlGenerator
$this->assetUrlGenerator->setRequest($request);
$this->prepareRequest($request);
try {
// Try to match a route, check if the client can access it and add
@ -169,19 +152,7 @@ class Application implements RouterAwareInterface, AuthenticationManagerAwareInt
$response = new Response((string)$response);
}
// Attach operator's authentication info to the response to distinguish
// him in the next requests.
$authentication_manager->attachOperatorToResponse($response);
// Cache user's locale in the cookie. The code below should be treated
// as a temporary workaround.
// TODO: Move the following lines to Locales Manager when object
// oriented approach for locales will be implemented.
$response->headers->setCookie($cookie_factory->createCookie(
LOCALE_COOKIE_NAME,
get_current_locale(),
time() + 60 * 60 * 24 * 1000
));
$this->finalizeRequest($request, $response);
return $response;
}
@ -232,6 +203,56 @@ class Application implements RouterAwareInterface, AuthenticationManagerAwareInt
return $this->authenticationManager;
}
/**
* Prepare request to be processed.
*
* @param Request $request Fresh incoming request.
*/
protected function prepareRequest(Request $request)
{
// Actualize request context in the internal router instance
$context = new RequestContext();
$context->fromRequest($request);
$this->getRouter()->setContext($context);
$authentication_manager = $this->getAuthenticationManager();
// Actualize cookie factory in the authentication manager if it is
// needed.
if ($authentication_manager instanceof CookieFactoryAwareInterface) {
$authentication_manager->setCookieFactory(CookieFactory::fromRequest($request));
}
$authentication_manager->setOperatorFromRequest($request);
// Actualize AssetUrlGenerator
$this->assetUrlGenerator->setRequest($request);
}
/**
* Finalize the request and make sure that the response is in compliance
* with it.
*
* @param Request $request The processed request.
* @param Response $response The response which should be set to the client.
*/
protected function finalizeRequest(Request $request, Response $response)
{
// Attach operator's authentication info to the response to distinguish
// him in the next requests.
$this->getAuthenticationManager()->attachOperatorToResponse($response);
// Cache user's locale in the cookie. The code below should be treated
// as a temporary workaround.
// TODO: Move the following lines to Locales Manager when object
// oriented approach for locales will be implemented.
$response->headers->setCookie(CookieFactory::fromRequest($request)->createCookie(
LOCALE_COOKIE_NAME,
get_current_locale(),
time() + 60 * 60 * 24 * 1000
));
$response->prepare($request);
}
/**
* Builds response for pages with denied access
*