Do not use global $page array in setup_group_settings_tabs function

This commit is contained in:
Dmitriy Simushev 2014-01-15 15:15:07 +00:00
parent 70699aeecd
commit 3f667e8fa6
3 changed files with 16 additions and 8 deletions

View File

@ -39,17 +39,25 @@ function get_group_name($group)
return $group['vccommonname']; return $group['vccommonname'];
} }
function setup_group_settings_tabs($gid, $active) /**
{ * Builds list of group settings tabs. The keys are tabsa titles and the values
global $page; * are tabs URLs.
*
* @param int $gid Group ID
* @param int $active Number of the active tab.
* @return array Tabs list
*/
function setup_group_settings_tabs($gid, $active) {
$tabs = array();
if ($gid) { if ($gid) {
$page['tabs'] = array( $tabs = array(
getlocal("page_group.tab.main") => $active != 0 ? (MIBEW_WEB_ROOT . "/operator/group.php?gid=$gid") : "", getlocal("page_group.tab.main") => $active != 0 ? (MIBEW_WEB_ROOT . "/operator/group.php?gid=$gid") : "",
getlocal("page_group.tab.members") => $active != 1 ? (MIBEW_WEB_ROOT . "/operator/groupmembers.php?gid=$gid") : "", getlocal("page_group.tab.members") => $active != 1 ? (MIBEW_WEB_ROOT . "/operator/groupmembers.php?gid=$gid") : "",
); );
} else {
$page['tabs'] = array();
} }
return $tabs;
} }
function get_operator_groupslist($operatorid) function get_operator_groupslist($operatorid)

View File

@ -253,7 +253,7 @@ $page['title'] = getlocal("page.group.title");
$page['menuid'] = "groups"; $page['menuid'] = "groups";
prepare_menu($operator); prepare_menu($operator);
setup_group_settings_tabs($groupid, 0); $page['tabs'] = setup_group_settings_tabs($groupid, 0);
$page_style = new PageStyle(PageStyle::currentStyle()); $page_style = new PageStyle(PageStyle::currentStyle());
$page_style->render('group'); $page_style->render('group');

View File

@ -96,7 +96,7 @@ $page['title'] = getlocal("page.groupmembers.title");
$page['menuid'] = "groups"; $page['menuid'] = "groups";
prepare_menu($operator); prepare_menu($operator);
setup_group_settings_tabs($groupid, 1); $page['tabs'] = setup_group_settings_tabs($groupid, 1);
$page_style = new PageStyle(PageStyle::currentStyle()); $page_style = new PageStyle(PageStyle::currentStyle());
$page_style->render('groupmembers'); $page_style->render('groupmembers');