Mibew/mibew
1
0
Fork 0
mirror of https://github.com/Mibew/mibew.git synced 2025-01-31 05:20:30 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't call set_csrf_token() function in controllers

Browse Source
This commit is contained in:
Dmitriy Simushev 2015-03-27 15:19:10 +00:00
parent b56881bf01
commit 1a358c2f09
22 changed files with 5 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mibew/libs/classes/Mibew/Controller/BanController.php
View File

@ -38,8 +38,6 @@ class BanController extends AbstractController
*/
public function indexAction(Request $request)
{
set_csrf_token();
$operator = $this->getOperator();
$page = array(
'errors' => array(),
@ -108,8 +106,6 @@ class BanController extends AbstractController
*/
public function showEditFormAction(Request $request)
{
set_csrf_token();
$operator = $this->getOperator();
$page = array(

4
src/mibew/libs/classes/Mibew/Controller/CannedMessageController.php
View File

@ -35,8 +35,6 @@ class CannedMessageController extends AbstractController
*/
public function indexAction(Request $request)
{
set_csrf_token();
$operator = $this->getOperator();
$page = array(
'errors' => array(),
@ -145,8 +143,6 @@ class CannedMessageController extends AbstractController
*/
public function showEditFormAction(Request $request)
{
set_csrf_token();
$operator = $this->getOperator();
$message_id = $request->attributes->getInt('message_id');
$page = array(

2
src/mibew/libs/classes/Mibew/Controller/Group/ManagementController.php
View File

@ -35,8 +35,6 @@ class ManagementController extends AbstractController
*/
public function indexAction(Request $request)
{
set_csrf_token();
$operator = $this->getOperator();
$page = array(
'errors' => array(),

2
src/mibew/libs/classes/Mibew/Controller/Group/MembersController.php
View File

@ -37,8 +37,6 @@ class MembersController extends AbstractController
*/
public function showFormAction(Request $request)
{
set_csrf_token();
$operator = $this->getOperator();
$group_id = $request->attributes->getInt('group_id');

2
src/mibew/libs/classes/Mibew/Controller/Group/SettingsController.php
View File

@ -38,8 +38,6 @@ class SettingsController extends AbstractController
*/
public function showFormAction(Request $request)
{
set_csrf_token();
$operator = $this->getOperator();
$group_id = $request->attributes->getInt('group_id');

2
src/mibew/libs/classes/Mibew/Controller/Localization/LocaleController.php
View File

@ -35,8 +35,6 @@ class LocaleController extends AbstractController
*/
public function indexAction(Request $request)
{
set_csrf_token();
$operator = $this->getOperator();
$page = array(
// Use errors list stored in the request. We need to do so to have

2
src/mibew/libs/classes/Mibew/Controller/Localization/TranslationController.php
View File

@ -118,8 +118,6 @@ class TranslationController extends AbstractController
*/
public function showEditFormAction(Request $request)
{
set_csrf_token();
$operator = $this->getOperator();
$string_id = $request->attributes->get('string_id');
$string = $this->loadString($string_id);

1
src/mibew/libs/classes/Mibew/Controller/Localization/TranslationExportController.php
View File

@ -37,7 +37,6 @@ class TranslationExportController extends AbstractController
*/
public function showFormAction(Request $request)
{
set_csrf_token();
$operator = $this->getOperator();
$target = $request->request->get('target');

1
src/mibew/libs/classes/Mibew/Controller/Localization/TranslationImportController.php
View File

@ -35,7 +35,6 @@ class TranslationImportController extends AbstractController
*/
public function showFormAction(Request $request)
{
set_csrf_token();
$operator = $this->getOperator();
$target = $request->request->get('target');

2
src/mibew/libs/classes/Mibew/Controller/LoginController.php
View File

@ -34,8 +34,6 @@ class LoginController extends AbstractController
*/
public function showFormAction(Request $request)
{
set_csrf_token();
// Check if the operator already logged in
if ($this->getOperator()) {
// Redirect the operator to home page.

2
src/mibew/libs/classes/Mibew/Controller/MailTemplateController.php
View File

@ -74,8 +74,6 @@ class MailTemplateController extends AbstractController
*/
public function showEditFormAction(Request $request)
{
set_csrf_token();
$operator = $this->getOperator();
$lang = $this->extractLocale($request);
$template_name = $request->attributes->get('name');

2
src/mibew/libs/classes/Mibew/Controller/Operator/AvatarController.php
View File

@ -38,8 +38,6 @@ class AvatarController extends AbstractController
*/
public function showFormAction(Request $request)
{
set_csrf_token();
$operator = $this->getOperator();
$op_id = $request->attributes->get('operator_id');
$page = array(

2
src/mibew/libs/classes/Mibew/Controller/Operator/GroupsController.php
View File

@ -37,8 +37,6 @@ class GroupsController extends AbstractController
*/
public function showFormAction(Request $request)
{
set_csrf_token();
$operator = $this->getOperator();
$operator_in_isolation = in_isolation($operator);
$op_id = $request->attributes->getInt('operator_id');

2
src/mibew/libs/classes/Mibew/Controller/Operator/ManagementController.php
View File

@ -35,8 +35,6 @@ class ManagementController extends AbstractController
*/
public function indexAction(Request $request)
{
set_csrf_token();
$operator = $this->getOperator();
$page = array(
// Use errors list stored in the request. We need to do so to have

2
src/mibew/libs/classes/Mibew/Controller/Operator/PermissionsController.php
View File

@ -37,8 +37,6 @@ class PermissionsController extends AbstractController
*/
public function showFormAction(Request $request)
{
set_csrf_token();
$operator = $this->getOperator();
$op_id = $request->attributes->get('operator_id');

2
src/mibew/libs/classes/Mibew/Controller/Operator/ProfileController.php
View File

@ -38,8 +38,6 @@ class ProfileController extends AbstractController
*/
public function showFormAction(Request $request)
{
set_csrf_token();
$operator = $this->getOperator();
$page = array(
'opid' => false,

4
src/mibew/libs/classes/Mibew/Controller/PasswordRecoveryController.php
View File

@ -38,8 +38,6 @@ class PasswordRecoveryController extends AbstractController
*/
public function indexAction(Request $request)
{
set_csrf_token();
if ($this->getOperator()) {
// If the operator is logged in just redirect him to the home page.
return $this->redirect($request->getUriForPath('/operator'));
@ -132,8 +130,6 @@ class PasswordRecoveryController extends AbstractController
*/
public function resetAction(Request $request)
{
set_csrf_token();
$page = array(
'version' => MIBEW_VERSION,
'showform' => true,

2
src/mibew/libs/classes/Mibew/Controller/PluginController.php
View File

@ -38,8 +38,6 @@ class PluginController extends AbstractController
*/
public function indexAction(Request $request)
{
set_csrf_token();
$page = array(
// Use errors list stored in the request. We need to do so to have
// an ability to pass errors from another actions.

2
src/mibew/libs/classes/Mibew/Controller/Settings/CommonController.php
View File

@ -41,8 +41,6 @@ class CommonController extends AbstractController
*/
public function showFormAction(Request $request)
{
set_csrf_token();
$operator = $this->getOperator();
$page = array(

2
src/mibew/libs/classes/Mibew/Controller/Settings/FeaturesController.php
View File

@ -35,8 +35,6 @@ class FeaturesController extends AbstractController
*/
public function showFormAction(Request $request)
{
set_csrf_token();
$operator = $this->getOperator();
$page = array(
'agentId' => '',

2
src/mibew/libs/classes/Mibew/Controller/Settings/PerformanceController.php
View File

@ -35,8 +35,6 @@ class PerformanceController extends AbstractController
*/
public function showFormAction(Request $request)
{
set_csrf_token();
$operator = $this->getOperator();
$page = array(
'agentId' => '',

6
src/mibew/libs/common/csrf.php
View File

@ -57,7 +57,11 @@ function get_csrf_token()
return $_SESSION[SESSION_PREFIX . 'csrf_token'];
}
/* set csrf token */
/**
* Sets CSRF token.
*
* This function is internal and should not be used directly in controllers.
*/
function set_csrf_token()
{
if (!isset($_SESSION[SESSION_PREFIX . 'csrf_token'])) {