mirror of
https://github.com/Mibew/simple-icons.git
synced 2024-11-15 18:04:12 +03:00
9cee719fcb
* Check outlying precision while running linter * Prevent reduce error on empty array * Rebase on branch develop * Add svgpath dep * Improve decimal precision verification * Check outlying precision while running linter * Prevent reduce error on empty array * Fix ignored file * Fix reverted dep version * Check decimal according to review proposal * Pin svgpath version * Use te maximum precision only * Run linter again * Fix uglify-js version * Add supported engines to package.json * Improve message * Revert engines and use version check in linter * Move function * Update node version to 12 in Travis * Add skip ignored
207 lines
7.3 KiB
JavaScript
207 lines
7.3 KiB
JavaScript
const fs = require('fs');
|
|
|
|
const data = require("./_data/simple-icons.json");
|
|
const { htmlFriendlyToTitle } = require("./scripts/utils.js");
|
|
const getBounds = require("svg-path-bounding-box");
|
|
const parsePath = require("svgpath/lib/path_parse");
|
|
|
|
const titleRegexp = /(.+) icon$/;
|
|
const svgRegexp = /^<svg( [^\s]*=".*"){3}><title>.*<\/title><path d=".*"\/><\/svg>\r?\n?$/;
|
|
|
|
const iconSize = 24;
|
|
const iconFloatPrecision = 3;
|
|
const iconMaxFloatPrecision = 5;
|
|
const iconTolerance = 0.001;
|
|
|
|
// set env SI_UPDATE_IGNORE to recreate the ignore file
|
|
const updateIgnoreFile = process.env.SI_UPDATE_IGNORE === 'true'
|
|
const ignoreFile = "./.svglint-ignored.json";
|
|
const iconIgnored = !updateIgnoreFile ? require(ignoreFile) : {};
|
|
|
|
function sortObjectByKey(obj) {
|
|
return Object
|
|
.keys(obj)
|
|
.sort()
|
|
.reduce((r, k) => Object.assign(r, { [k]: obj[k] }), {});
|
|
}
|
|
|
|
function sortObjectByValue(obj) {
|
|
return Object
|
|
.keys(obj)
|
|
.sort((a, b) => ('' + obj[a]).localeCompare(obj[b]))
|
|
.reduce((r, k) => Object.assign(r, { [k]: obj[k] }), {});
|
|
}
|
|
|
|
if (Array.prototype.flat === undefined) {
|
|
console.error(`Minimum NodeJS v11.15.0 is required, but you are running ${process.version}.`);
|
|
process.exit(1);
|
|
}
|
|
|
|
if (updateIgnoreFile) {
|
|
process.on('exit', () => {
|
|
// ensure object output order is consistent due to async svglint processing
|
|
const sorted = sortObjectByKey(iconIgnored)
|
|
for (const linterName in sorted) {
|
|
sorted[linterName] = sortObjectByValue(sorted[linterName])
|
|
}
|
|
|
|
fs.writeFileSync(
|
|
ignoreFile,
|
|
JSON.stringify(sorted, null, 2) + '\n',
|
|
{flag: 'w'}
|
|
);
|
|
});
|
|
}
|
|
|
|
function isIgnored(linterName, path) {
|
|
return iconIgnored[linterName].hasOwnProperty(path);
|
|
}
|
|
|
|
function ignoreIcon(linterName, path, $) {
|
|
if (!iconIgnored[linterName]) {
|
|
iconIgnored[linterName] = {};
|
|
}
|
|
|
|
const title = $.find("title").text().replace(/(.*) icon/, '$1');
|
|
const iconName = htmlFriendlyToTitle(title);
|
|
|
|
iconIgnored[linterName][path] = iconName;
|
|
}
|
|
|
|
module.exports = {
|
|
rules: {
|
|
elm: {
|
|
"svg": 1,
|
|
"svg > title": 1,
|
|
"svg > path": 1,
|
|
"*": false,
|
|
},
|
|
attr: [
|
|
{ // ensure that the SVG elm has the appropriate attrs
|
|
"role": "img",
|
|
"viewBox": `0 0 ${iconSize} ${iconSize}`,
|
|
"xmlns": "http://www.w3.org/2000/svg",
|
|
"rule::selector": "svg",
|
|
"rule::whitelist": true,
|
|
},
|
|
{ // ensure that the title elm has the appropriate attr
|
|
"rule::selector": "svg > title",
|
|
"rule::whitelist": true,
|
|
},
|
|
{ // ensure that the path element only has the 'd' attr (no style, opacity, etc.)
|
|
"d": /^[,a-zA-Z0-9\. -]+$/,
|
|
"rule::selector": "svg > path",
|
|
"rule::whitelist": true,
|
|
}
|
|
],
|
|
custom: [
|
|
function(reporter, $, ast) {
|
|
reporter.name = "icon-title";
|
|
|
|
const iconTitleText = $.find("title").text();
|
|
if (!titleRegexp.test(iconTitleText)) {
|
|
reporter.error("<title> should follow the format \"[ICON_NAME] icon\"");
|
|
} else {
|
|
const titleMatch = iconTitleText.match(titleRegexp);
|
|
// titleMatch = [ "[ICON_NAME] icon", "[ICON_NAME]" ]
|
|
const rawIconName = titleMatch[1];
|
|
const iconName = htmlFriendlyToTitle(rawIconName);
|
|
const icon = data.icons.find(icon => icon.title === iconName);
|
|
if (icon === undefined) {
|
|
reporter.error(`No icon with title "${iconName}" found in simple-icons.json`);
|
|
}
|
|
}
|
|
},
|
|
function(reporter, $, ast) {
|
|
reporter.name = "icon-size";
|
|
|
|
const iconPath = $.find("path").attr("d");
|
|
if (!updateIgnoreFile && isIgnored(reporter.name, iconPath)) {
|
|
return;
|
|
}
|
|
|
|
const bounds = getBounds(iconPath);
|
|
const width = +bounds.width.toFixed(iconFloatPrecision);
|
|
const height = +bounds.height.toFixed(iconFloatPrecision);
|
|
|
|
if (width === 0 && height === 0) {
|
|
reporter.error("Path bounds were reported as 0 x 0; check if the path is valid");
|
|
if (updateIgnoreFile) {
|
|
ignoreIcon(reporter.name, iconPath, $);
|
|
}
|
|
} else if (width !== iconSize && height !== iconSize) {
|
|
reporter.error(`Size of <path> must be exactly ${iconSize} in one dimension; the size is currently ${width} x ${height}`);
|
|
if (updateIgnoreFile) {
|
|
ignoreIcon(reporter.name, iconPath, $);
|
|
}
|
|
}
|
|
},
|
|
function(reporter, $, ast) {
|
|
reporter.name = "icon-precision";
|
|
|
|
const iconPath = $.find("path").attr("d");
|
|
if (!updateIgnoreFile && isIgnored(reporter.name, iconPath)) {
|
|
return;
|
|
}
|
|
|
|
const { segments } = parsePath(iconPath);
|
|
const segmentParts = segments.flat().filter((num) => (typeof num === 'number'));
|
|
|
|
const countDecimals = (num) => {
|
|
if (num && num % 1) {
|
|
let [base, op, trail] = num.toExponential().split(/e([+-])/);
|
|
let elen = parseInt(trail, 10);
|
|
let idx = base.indexOf('.');
|
|
return idx == -1 ? elen : base.length - idx - 1 + (op === '+' ? -elen : elen);
|
|
}
|
|
return 0;
|
|
};
|
|
const precisionArray = segmentParts.map(countDecimals);
|
|
const precisionMax = precisionArray && precisionArray.length > 0 ?
|
|
Math.max(...precisionArray) :
|
|
0;
|
|
|
|
if (precisionMax > iconMaxFloatPrecision) {
|
|
reporter.error(`Maximum precision should not be greater than ${iconMaxFloatPrecision}; it is currently ${precisionMax}`);
|
|
if (updateIgnoreFile) {
|
|
ignoreIcon(reporter.name, iconPath, $);
|
|
}
|
|
}
|
|
},
|
|
function(reporter, $, ast) {
|
|
reporter.name = "extraneous";
|
|
|
|
const rawSVG = $.html();
|
|
if (!svgRegexp.test(rawSVG)) {
|
|
reporter.error("Unexpected character(s), most likely extraneous whitespace, detected in SVG markup");
|
|
}
|
|
},
|
|
function(reporter, $, ast) {
|
|
reporter.name = "icon-centered";
|
|
|
|
const iconPath = $.find("path").attr("d");
|
|
if (!updateIgnoreFile && isIgnored(reporter.name, iconPath)) {
|
|
return;
|
|
}
|
|
|
|
const bounds = getBounds(iconPath);
|
|
const targetCenter = iconSize / 2;
|
|
const centerX = +((bounds.minX + bounds.maxX) / 2).toFixed(iconFloatPrecision);
|
|
const devianceX = centerX - targetCenter;
|
|
const centerY = +((bounds.minY + bounds.maxY) / 2).toFixed(iconFloatPrecision);
|
|
const devianceY = centerY - targetCenter;
|
|
|
|
if (
|
|
Math.abs(devianceX) > iconTolerance ||
|
|
Math.abs(devianceY) > iconTolerance
|
|
) {
|
|
reporter.error(`<path> must be centered at (${targetCenter}, ${targetCenter}); the center is currently (${centerX}, ${centerY})`);
|
|
if (updateIgnoreFile) {
|
|
ignoreIcon(reporter.name, iconPath, $);
|
|
}
|
|
}
|
|
}
|
|
]
|
|
}
|
|
};
|