# Fix indentation of format function.
# Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>
# Update formatting in scripts/lint.js
# Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>
# Fix Handshake order
# Require Sorting by Slug
* Accept icon rather than title in `iconToSlug`
This removes the need in (most of the) calls to this function to
seperately check if there is a custom slug already defined for the icon.
* Rename `titleToSlug` to `getIconSlug`
* Revert unnecessary style change
* Update function documentation
* Keep `titleToSlug` and add `getIconSlug` helper
Unfortunately `this` is not available because we're using arrow syntax
for these functions, but refering to `titleToSlug` through
`module.exports` works fine as well.
* Fix parameter name in `getIconSlug` docs
* Add "license" object to the data file JSON schema
* Add license to GNU and GNU social
As an example, based on the discussion in:
https://github.com/simple-icons/simple-icons/issues/1167
* Use `"additionalProperties": false` in JSON schema
... to detect properties in the data file that shouldn't be there.
For more info, see:
https://json-schema.org/understanding-json-schema/reference/object.html
* Update JSON scheme descriptions
* Switch from jsonlint2 to jsonschema
This gives is better support for advanced features of JSON schema.
A couple of clarifications:
- There does exist a jsonschema-cli package, but it is rather limited
and crucially doens't exit with a non-zero exit code if there is an
error. (it is also pretty old and not maintained), hence the custom
script.
- I renamed .jsonlintschema 1) for clarity (lint is no longer accurate)
and 2) the .json extension allows easy imorting in the script and 3)
it adds syntax highlighting.
- The script outputs the number of errors in the end because the output
gets pretty big pretty quickly, this way you can see it easily from
your CLI.
- We could customize how the errors are logged, but I feel that is
beyond this PR.
* Two minor changes
* Use `oneOf` to require URL for custom licenses
The updated configuration allows the `"license"` field to be either
1) a SPDX license, optional with a URL
2) a "custom" license with a required URL
Read more about the "oneOf" feature of jsonschema at:
https://json-schema.org/understanding-json-schema/reference/combining.html#oneof
* Include license field in Contributing Guidelines
- Rename `titleToFilename` to `titleToSlug`
- Fix indentation where necessary
- Use quotes internally consistently (to reduce the diff size, unfortunately this is the opposite quote from what we use in other projects)
- Update comments & documentation
- Construct file paths
And more...
* Remove .travis.yml reference from .gitattributes
* Minor refactoring of .svglintrc.js
- Remove unused variables
- Fix missing semi-colons
- Remove unneeded indentation
* Prevent error in clean command due to missing files
* Fix indentations
* Further improvements to Editorconfig and indentation
* Format YAML files
- Update indentation for array notation
- Normalize use of newlines
Remove redundant truthy check for properties of icons in index.js
We test if all icon scan be retrieved anyway, if any icon is missing these properties we would find out during testing.
* Add test for check JSON data file prettification
* Move prettification test to out linting script
* Add other newline in error message to improve readability
* Invert the diff to show the solution to the user
* Add 'jest-diff' as direct dependency
* Remove annotations and colors
* Replace CRLF newlines with LFs in JSON prettification lint
* Restore colors in JSON prettification lint
* Create simple CLI tool to get the filename from a brandname
https://github.com/simple-icons/simple-icons/pull/2589#issuecomment-585902427
* Update contributing guidelines on new SVGs' filenames
* Fix incorrect filename in package.json script
* Add file header to get-filename script
* Update contributing guidelines' section on SVG filenames
Co-Authored-By: YoussefRaafatNasry <youssefraafatnasry@gmail.com>
* Add a script for the linting that cannot be accomplished by our other linters
Currently this only contains linting for whether our icons are alphabetically sorted
* Add our own linting to Travis
* Fix Let's Encrypt being incorrectly sorted
* Intentionally break sorting to test CI
* Revert "Intentionally break sorting to test CI"
This reverts commit 55e4070b3c3294cff306fcc138ce247843130c35.
* Explain in CONTRIBUTION.md how to sort metadata
* Introduce newline into a SVG
for testing purposes
* Remove potential newlines from SVGs when building the package
* Don't lint SVG files
... so it is neither required to have, or not have, a final newline
* Remove both Windows and Unix style newlines in build script
* Rever 3372ca3
* Refactor prepublish script to use template file for icon objects
... to hopefully increase readability
* Fix build and test issues
* Add missing semi-colon
* Explicitly check for errors when writing individual static .js files
* Reduce package size by replacing JSON.stringify by custom stringify func
* Escape icon's title and SVG value
... as pointed out by @birjolaxew, if they contain a "'" it will break
the resulting object.
* Add URL friendy/slug/file name as property to package icon objects
* Test new property
* Build index from template
* Add .get function to index.js export
* Test new .get function in index.js export
* Use Uglify-JS to minify the code in the package's index.js
* Update API in README.md
* Renaem test using "slug" instead of "name"
* Add URL friendy/slug/file name as property to package icon objects
* Test new property
* Add 'name' property to examples in README
* Rename "name" property to "slug"
* Reduce package size by replacing JSON.stringify by custom stringify func
* Replace path data by getter
* Replace getter by Object.defineProperty
* Remove icon.path definition
* Revert 801c07d4
Apperantly getters have better support then Objct.defineProperty...
* Add custom SVGLint rule to lint the general <title> format
i.e. the <title> should be "[ICON_NAME] icon"
* Check if there exists an entry in simple-icons.json with the icon name
... found in the <title>
* Normalize all icons <title> value
* Fix mismatch between HTML's icon title and simple-icons.json title
... due to HTML special entities (such as `&`). Affected icons:
- AT&T (AT&T)
- Let's Encrypt (Let's Encrypt)
* Refactor .svglintrc.js
to make the code style more in line with scripts/prepublish.js
* Add SVG with invalid <title> format
* Add SVG with unknown title
* Revert 6912816 and f002504
* Update prepublish script to add path to generated .js files
* Test generated path values
* Fix Furry Network icon
The Furry Network icon used to have "e"s in the path, however the
official SVG definition does not specify the E command.
source: https://www.w3schools.com/graphics/svg_path.asp
Because it was renamed it may result in unexpected errors --> breaking
changes.
This is a temporary solution to circumvent the problem. This can be
removed once some other breaking changes are also present and a major
new version is released. I propose removing this change when
https://github.com/simple-icons/simple-icons/issues/1362 is implemented
* add new icons
- add icon for AT&T
- add icon for T-mobile
- add icon for Sprint
- add icon for Cricket
- add icon for Verizon
- add icon for Boost
- add icon for Framer
- add icon for Sketch
- Update _data/simple-icons.json with new icon data
* remove `<g>` from svg files
- remove `<g>` from svg files to address svglint error
* add apple pay
- Add apple pay
- Update simple-icons.json
* make changes per review
Changes were made based on review 9/9/18.
* fixed AT&T naming
* Add prepublish script
Compiles icons into both static js files (icons/{filename}.js) and
into a static index.js. The latter is not tree-shakeable.
Closes#941, closes#751
* Add information on tree-shaking to README
* Remove index.js after publishing
* Change 'prepublish' to 'prepublishOnly'
* Link to webpack in README
* Simplify postpublish cleanup
Thanks @ericcornelissen
* Fix quote usage in prepublish.js
* Fix quote usage in utils.js
* Optimized file size of prepublish output
* Improved readability of prepublish script
