From e1bd4104b13b473a974bc4218312bd0fcd08ff8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=81lvaro=20Mond=C3=A9jar=20Rubio?= Date: Sun, 13 Oct 2024 04:31:07 +0200 Subject: [PATCH] Use lychee instead of markdown-link-check on CI (#12001) --- .github/markdown-link-check.json | 7 ------- .github/workflows/verify.yml | 11 +++++++---- package.json | 1 - 3 files changed, 7 insertions(+), 12 deletions(-) delete mode 100644 .github/markdown-link-check.json diff --git a/.github/markdown-link-check.json b/.github/markdown-link-check.json deleted file mode 100644 index db3f68ae..00000000 --- a/.github/markdown-link-check.json +++ /dev/null @@ -1,7 +0,0 @@ -{ - "ignorePatterns": [ - { - "pattern": "^https://www.similarweb.com" - } - ] -} diff --git a/.github/workflows/verify.yml b/.github/workflows/verify.yml index 611f41ae..f77c9001 100644 --- a/.github/workflows/verify.yml +++ b/.github/workflows/verify.yml @@ -58,11 +58,14 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - name: Check documentation links if: steps.changes.outputs.docs == true - run: | - npx markdown-link-check --retry \ - --config .github/markdown-link-check.json \ + uses: lycheeverse/lychee-action@v2 + with: + args: --exclude ^https://www.similarweb.com -- \ ${{ steps.changes.outputs.docs_files }} - continue-on-error: ${{ github.ref == 'refs/heads/develop' }} + fail: ${{ github.ref != 'refs/heads/develop' }} + jobSummary: true + format: markdown + token: ${{ secrets.GITHUB_TOKEN }} - name: Verify file permissions run: | CHECK_DIRS="icons/ _data/" diff --git a/package.json b/package.json index f66fdc50..405b3bd8 100644 --- a/package.json +++ b/package.json @@ -98,7 +98,6 @@ "husky": "9.0.11", "inquirer-autocomplete-standalone": "0.8.1", "jsonschema": "1.4.1", - "markdown-link-check": "3.12.1", "mocha": "10.4.0", "named-html-entities-json": "1.0.0", "spdx-license-ids": "3.0.20",