From d183067776f7f1420a8ab3beb1f48030e874d835 Mon Sep 17 00:00:00 2001 From: Johan Fagerberg Date: Wed, 6 Sep 2017 13:23:41 +0200 Subject: [PATCH] Updated ARIA guidelines Following issue from #503 --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ed737ebd..ce14ab29 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -3,8 +3,8 @@ This repository welcomes contributions and corrections. Before submitting a pull request, ensure that you respect these guidelines for SVGs: - Include the SVG namespace declaration `xmlns="http://www.w3.org/2000/svg"`. This is not required if the SVG is included inline on HTML5 web pages. - - Include a descriptive `` element for accessibility. For example, `<title>GitHub icon`. - - Add `aria-labelledby="title"` and `role="img"` to the `` element to improve screen reader support. + - Include a descriptive `` element for accessibility. The `` must have an ID of the format `simpleicon-<iconname>-title` - for example, `<title id="simpleicon-github-title">GitHub icon`. + - Add `aria-labelledby="simpleicon--title"` and `role="img"` to the `` element to improve screen reader support. - Use a `viewBox` of 24 by 24, following [Google’s Material Design guidelines for system icons](https://material.io/guidelines/style/icons.html#icons-system-icons). - Ensure that all paths and strokes have been converted to fills. - Ensure your SVG is monochromatic. Remove all fill colors so that icons default to black.