Mibew/simple-icons
1
0
Fork 0
mirror of https://github.com/Mibew/simple-icons.git synced 2025-10-31 18:41:07 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add svg linter to check center (#3250)

Browse Source 
This adds a tolerance of +/- 0.001 to either the X or Y dimensions,
adjusting the existing ignore list and size linter to fit the new
structure of the ignore file.

See https://github.com/simple-icons/simple-icons/pull/3107#issuecomment-648089119
This commit is contained in:
David Beitey 2020-07-10 08:06:08 +00:00 committed by GitHub
parent 4ab6532e18
commit cc509d9246
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 402 additions and 291 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

665
.svglint-ignored.json
View File

File diff suppressed because one or more lines are too long

28
.svglintrc.js
View File

@ -7,6 +7,7 @@ const svgRegexp = /^<svg( [^\s]*=".*"){3}><title>.*<\/title><path d=".*"\/><\/sv
const iconSize = 24;
const iconFloatPrecision = 3;
const iconTolerance = 0.001;
const iconIgnored = require("./.svglint-ignored.json");
module.exports = {
@ -58,7 +59,7 @@ module.exports = {
reporter.name = "icon-size";
const iconPath = $.find("path").attr("d");
if (iconIgnored.hasOwnProperty(iconPath)) {
if (iconIgnored.size.hasOwnProperty(iconPath)) {
return;
}
@ -80,6 +81,31 @@ module.exports = {
reporter.error("Unexpected character(s), most likely extraneous whitespace, detected in SVG markup");
}
},
function(reporter, $, ast) {
reporter.name = "icon-centered";
const iconPath = $.find("path").attr("d");
const bounds = getBounds(iconPath);
if (
iconIgnored.size.hasOwnProperty(iconPath) ||
iconIgnored.center.hasOwnProperty(iconPath)
) {
return
}
const targetCenter = iconSize / 2;
const centerX = +((bounds.minX + bounds.maxX) / 2).toFixed(iconFloatPrecision);
const devianceX = centerX - targetCenter;
const centerY = +((bounds.minY + bounds.maxY) / 2).toFixed(iconFloatPrecision);
const devianceY = centerY - targetCenter;
if (
Math.abs(devianceX) > iconTolerance ||
Math.abs(devianceY) > iconTolerance
) {
reporter.error(`<path> must be centered at (${targetCenter}, ${targetCenter}); the center is currently (${centerX}, ${centerY})`);
}
}
]
}
};